Pre-Submission vs. Formal Merge/Pull Request Code Reviews
Posted by crmpicco@reddit | ExperiencedDevs | View on Reddit | 6 comments
I've recently been exploring ways to integrate AI-assisted code reviews into my GitLab workflow. I've found PR Agent to be a promising tool. It integrates nicely with .gitlab-ci.yml and can be triggered conditionally for merge requests, providing a lightweight and immediate review. So far, I'm really impressed with its potential! 👍
My current strategic question is about the timing and scope of code reviews. While PR Agent offers great in-GitLab automated reviews, I'm wondering about the practice of performing a pre-submission review on a developer's local environment before the formal merge request is even created.
My dilemma is this:
- Is it a good idea to have an automated, local pre-submission review AND then a formal, in-GitLab review (whether automated or human)? Or is this process redundant?
- My primary concern with relying solely on local pre-submission reviews is the lack of an auditable record. If all the initial review happens exclusively on a developer's machine, there's no easily accessible history of that review process within GitLab for future reference, compliance, or knowledge sharing.
I'm curious to hear from others on how you approach this. What are your team's best practices for balancing local checks with formal, documented code reviews in GitLab? Any insights or patterns you've adopted would be greatly appreciated!
ExperiencedDevs-ModTeam@reddit
Rule 8: No Surveys/Advertisements
If you think this shouldn't apply to you, get approval from moderators first.
itsmegoddamnit@reddit
Spam
Empanatacion@reddit
Lame! They edited their post from a plausible question into a spam link.
LittleLordFuckleroy1@reddit
Slop shill spam. This sub isn’t an ad board.
Empanatacion@reddit
They'll be mostly redundant if it's the same model underneath. Baking it in remotely lowers the friction so it happens every time.
But do you actually have some auditing requirement? I don't see much actual quality-of-software value in tracking the review event. If a local AI review is catching something before the PR even lands, I don't think you've lost anything valuable by it not being recorded as a PR comment.
Honestly, does anybody ever go back to a merged PR weeks later to look at the conversation? To what end?
PmMeCuteDogsThanks_@reddit
I’ve done it to filter out what people just press approve and never comment (or just a ”lgtm”). They provide nothing of value to the processÂ