C Programming. PLEASE HELP!
Posted by Slow-Crab-8351@reddit | learnprogramming | View on Reddit | 2 comments
I need help finishing this code. My delete node function is deleting excessive nodes when the node has two children. Can anyone help me?
Node* findMin(Node* node) {
if (!node) return NULL;
while (node->left != NULL){
node = node->left;
}
return node;
}
Node* deleteNode(Node* root, char* name) {
if (!root) return NULL;
int compare = strcmp(name, root->name);
if (compare < 0) {
root->left = deleteNode(root->left, name);
return root;
}
else if (compare > 0){
root->right = deleteNode(root->right, name);
return root;
}
else {//found the node to be deleted
printf("%s deleted\n", name);
if (!root->left) {
Node* temp = root->right;
free(root);
return temp;
} else if (!root->right) {
Node* temp = root->left;
free(root);
return temp;
}
Node* temp = findMin(root->right);
strcpy(root->name, temp->name);
root->tickets = temp->tickets;
root->right = deleteNode(root->right, temp->name);
free(temp);
free(root);
return root;
}
return root;
}
lurgi@reddit
Try the simplest possible case where the node has two children: A tree with just three nodes and you want to delete the root. Does it work? If not, that's great. You now have a very simple test case and you can step through the code with a debugger (or litter your code with print statements) and find out what's going on.
AlexanderEllis_@reddit
1) You can lay the code out in a code block to be more readable- indentation-less code is much more confusing. There's a button on the reddit editor for this.
2) More detail about what you're trying to do would be helpful- how many nodes is it supposed to delete? How many nodes does it delete? How are you calling this in the first place, this appears to me that nothing would actually happen if I ran this code since none of the functions are actually called?